Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3723 Card title on image is red when the card is not clickable #3729

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

bberndt-uaz
Copy link
Contributor

@bberndt-uaz bberndt-uaz commented Sep 17, 2024

Description

Closes #3723 by making these changes:

  • Update styling in the az_card_title_hover CSS library to target linked card titles.
  • Attach the az_card_title_hover library to any Cards paragraph with a card that has a link.
  • In the card theme template, add the text-reset class to all linked titles (since we can take care of this styling with a Bootstrap class).

Related issues

How to test

Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3729.probo.build

  1. Create a page with four Cards paragraphs to test the following:
    • Card title style: Title on image, card title added, link added to Link URL and Link Title
    • Card title style: Title on image, card title added, no link
    • Card title style: Title within card, card title added, link added to Link URL and Link Title
    • Card title style: Title within card, card title added, no link
  2. Save the page and confirm that the titles are white on the card image and black within cards. Title links should have an underline on hover.
  3. Edit the page again and add additional Cards paragraphs with the "Clickable cards" checkbox checked.
  4. Confirm that the styling of the initial cards hasn't changed and the styling of the new clickable cards is correct.

Test page with all steps completed: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3729.probo.build/brian-test-page

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@bberndt-uaz bberndt-uaz added the bug Something isn't working label Sep 17, 2024
@bberndt-uaz bberndt-uaz self-assigned this Sep 17, 2024
@bberndt-uaz bberndt-uaz linked an issue Sep 17, 2024 that may be closed by this pull request
@bberndt-uaz bberndt-uaz marked this pull request as ready for review September 17, 2024 23:00
@bberndt-uaz bberndt-uaz requested a review from a team as a code owner September 17, 2024 23:00
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Sep 17, 2024
Copy link
Contributor

@joshuasosa joshuasosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Tested on probo and the change looks good. Tested other card decks and compared card deck demo content as well.

@joeparsons
Copy link
Member

@bberndt-uaz Is going to look into whether this needs to be backported to 2.10.x

@joeparsons joeparsons merged commit 01b31cf into main Sep 18, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3723 branch September 18, 2024 17:23
@bberndt-uaz
Copy link
Contributor Author

I tested on a 2.10.6 site and confirmed that this issue only affects 2.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only bug Something isn't working patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Card title on image is red when the card is not clickable
6 participants